[AssetMapper] Shortening "Optimizing Performance" #19609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some meaning is lost, i'm not sure about this. |
|
IMO, the introduction says it all:
|
|
I've merged this ... but I reverted some changes. As @smnandre said, this felt like some meaning was lost. Also, don't forget that for newcomers, setting up all those features in their web servers can be very overwhelming. So, the mention to Cloudflare as a simple and valid alternative to all this is very important, even if it could feel a bit repetitive. I hope you understand the reasoning. Thanks Thomas. |
ThomasLandauer
added a commit
to ThomasLandauer/symfony-docs
that referenced
this pull request
Mar 3, 2024
I agree with your care about newcomers in symfony#19609 (comment) But those 3 paragraphs still sound like a Cloudflare commercial...
javiereguiluz
added a commit
that referenced
this pull request
Mar 4, 2024
…sLandauer) This PR was squashed before being merged into the 6.4 branch. Discussion ---------- [AssetMapper] Shortening "Optimizing Performance" Page: https://symfony.com/doc/6.4/frontend/asset_mapper.html#optimizing-performance I agree with your care about newcomers in #19609 (comment) But those 3 paragraphs still sound like a Cloudflare commercial... Please start reading at https://symfony.com/doc/6.4/frontend/asset_mapper.html#optimizing-performance > To make your AssetMapper-powered site fly,... Commits ------- 28d99f7 [AssetMapper] Shortening "Optimizing Performance"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Page: https://symfony.com/doc/6.4/frontend/asset_mapper.html#optimizing-performance
Main reason: No need to repeat Cloudflare over and over - it's in the introduction paragraph anyway.